(1) You have magic numbers like 10000 in the getMessages in ApiController. Follow the coding guidelines and pull these out as constants. summarize() should work for any language not just English. It should take a locale as input.
(2) Avoid inline styles in GroupFeedElement
(3) GroupFeedElement also has a long line.
Fix these and I'll apply your patch.
adprajap-sjsu2025-09-29 03:44
Hello Professor,
I have made the requested changes and have attached the patch. I also tested changing the default locale and have verified that it works correctly, and have attached the results here. Please let me know if you need any more changes.
This patch adds a button to generate AI summary of a thread using a locally hosted LLM on the Yioop server
rebased off main - ready for review
rebased-summary.patch
addressed the comments:
snake case for javascript functions do not show the summarize thread button if llm variables are not configured
patched-summary-09-17.patch
Hey Aditya,
Thanks for the patch update.
(1) You have magic numbers like 10000 in the getMessages in ApiController. Follow the coding guidelines and pull these out as constants. summarize() should work for any language not just English. It should take a locale as input. (2) Avoid inline styles in GroupFeedElement (3) GroupFeedElement also has a long line.
Fix these and I'll apply your patch.
Hello Professor,
I have made the requested changes and have attached the patch. I also tested changing the default locale and have verified that it works correctly, and have attached the results here. Please let me know if you need any more changes.
patched-summary-09-29.patch
rebased patch off main
summary-09-30.patch
Attachments:
summary.patch