viewgit/inc/functions.php:22 Function utf8_encode() is deprecated [8192]

Fix bug where a wiki page could be reverted in not logged in, a=chris

Chris Pollett [2022-11-04 19:Nov:th]
Fix bug where a wiki page could be reverted in not logged in, a=chris
Filename
src/controllers/StaticController.php
src/controllers/components/SocialComponent.php
diff --git a/src/controllers/StaticController.php b/src/controllers/StaticController.php
index 3fa3f3df9..ff90729ec 100644
--- a/src/controllers/StaticController.php
+++ b/src/controllers/StaticController.php
@@ -119,11 +119,12 @@ class StaticController extends Controller
             $page = "404";
         }
         $page_string = $this->getPage($page);
-        if ($page_string == "") {
+        if (empty($page_string)) {
             $page = "404";
             $page_string = $this->getPage($page);
         }
-        $data['PAGE'] = explode("END_HEAD_VARS", $page_string)[1];
+        $page_parts = explode("END_HEAD_VARS", $page_string);
+        $data['PAGE'] = $page_parts[1] ?? $page_parts[0];
         if (!isset($data["INCLUDE_SCRIPTS"])) {
             $data["INCLUDE_SCRIPTS"] = [];
         }
diff --git a/src/controllers/components/SocialComponent.php b/src/controllers/components/SocialComponent.php
index 73332c10e..62802d6f1 100644
--- a/src/controllers/components/SocialComponent.php
+++ b/src/controllers/components/SocialComponent.php
@@ -1800,7 +1800,8 @@ class SocialComponent extends Component implements CrawlConstants
                 if (isset($page_info["PAGE_NAME"])) {
                     $group_id = $page_info['GROUP_ID'];
                     $data["WIKI_PAGE_NAME"] = $page_info["PAGE_NAME"];
-                    $group = $group_model->getGroupById($group_id, $user_id);
+                    $group = $group_model->getGroupById($group_id, $user_id,
+                        true);
                     if ($group["OWNER_ID"] == $user_id ||
                         ($group["STATUS"] == C\ACTIVE_STATUS &&
                         $group["MEMBER_ACCESS"] == C\GROUP_READ_WIKI)) {
@@ -3077,7 +3078,7 @@ class SocialComponent extends Component implements CrawlConstants
         } else {
             $group_id = C\PUBLIC_GROUP_ID;
         }
-        $group = $group_model->getGroupById($group_id, $user_id);
+        $group = $group_model->getGroupById($group_id, $user_id, true);
         if (!$group || !isset($group["OWNER_ID"])) {
             if ($data['MODE'] !== 'api') {
                 if ($user_id == C\PUBLIC_USER_ID) {
ViewGit