viewgit/inc/functions.php:22 Function utf8_encode() is deprecated [8192]

Remove fragment from static start thread and comment, rework linkDropdown so works better with Safari, a=chris

Chris Pollett [2020-07-25 21:Jul:th]
Remove fragment from static start thread and comment, rework linkDropdown so works better with Safari, a=chris
Filename
src/css/search.css
src/views/elements/GroupfeedElement.php
src/views/helpers/OptionsHelper.php
diff --git a/src/css/search.css b/src/css/search.css
index 2aac1393a..fd84ab378 100755
--- a/src/css/search.css
+++ b/src/css/search.css
@@ -2968,7 +2968,7 @@ ul.link-dropdown ul li:last-child
     border-bottom-left-radius: 5px;
     border-bottom-right-radius: 5px;
 }
-ul.link-dropdown li input
+.dropdown-selector
 {
     background: #FCFCFC;
     border: 0;
@@ -2978,7 +2978,7 @@ ul.link-dropdown li input
     top: unset;
     width: unset;
 }
-ul.link-dropdown li input:hover
+.dropdown-selector:hover
 {
     background: #FCFCFC;
     border: 0;
@@ -2989,15 +2989,11 @@ ul.link-dropdown li a
     text-decoration: none;
     color: #000;
 }
-ul.link-dropdown > li:focus-within
+ul.link-dropdown > li:focus
 {
     padding:0;
 }
-ul.link-dropdown li:focus-within input
-{
-    padding: 2px 5px 2px 5px;
-}
-ul.link-dropdown li:focus-within a.opt-group
+ul.link-dropdown li:focus a.opt-group
 {
     padding-left: 10px;
     padding-right: 10px;
diff --git a/src/views/elements/GroupfeedElement.php b/src/views/elements/GroupfeedElement.php
index 4bdaa8288..08ebbcc8c 100644
--- a/src/views/elements/GroupfeedElement.php
+++ b/src/views/elements/GroupfeedElement.php
@@ -108,7 +108,7 @@ class GroupfeedElement extends Element implements CrawlConstants
         if (isset($data['JUST_THREAD']) && $logged_in && $page && !$is_status &&
             isset($data['GROUP_STATUS']) &&
             $data['GROUP_STATUS'] == C\ACTIVE_STATUS) {
-            $data['FRAGMENT'] = '#result-'.$page['ID'];
+            $data['FRAGMENT'] = '#result-' . $page['ID'];
             $just_fields = ["LIMIT" => "limit", "RESULTS_PER_PAGE" => "num",
                 "JUST_THREAD" => 'just_thread'];
             $hidden_form = "\n";
@@ -120,8 +120,7 @@ class GroupfeedElement extends Element implements CrawlConstants
             }
             ?>
             <div class='small-margin-current-activity button-group-result'>
-            <form action="./<?= $data['FRAGMENT']
-            ?>" method="post" ><?= $hidden_form ?>
+            <form method="post" ><?= $hidden_form ?>
             <input type="hidden" name="c" value="<?=
                 $data['CONTROLLER'] ?>" />
             <input type="hidden" name="a" value="groupFeeds" />
@@ -489,8 +488,8 @@ class GroupfeedElement extends Element implements CrawlConstants
         </noscript>
         <div id='start-thread' class="light-gray-box top-bottom-margin">
             <br />
-            <form action="./<?= $data['FRAGMENT']
-                ?>" method="post" ><?= $hidden_form ?>
+            <form method="post" ><?=
+                $hidden_form ?>
             <input type="hidden" name="c" value="<?=
                 $data['CONTROLLER'] ?>" />
             <input type="hidden" name="a" value="groupFeeds" />
diff --git a/src/views/helpers/OptionsHelper.php b/src/views/helpers/OptionsHelper.php
index b87528d76..fda6d88cd 100755
--- a/src/views/helpers/OptionsHelper.php
+++ b/src/views/helpers/OptionsHelper.php
@@ -177,8 +177,9 @@ class OptionsHelper extends Helper
             ?>
             <form class="dropdown-container" <?= $id_info ?>>
             <ul class="link-dropdown">
-                <li><b><input readonly="readonly" value='<?=$selected_text
-                    ?>' /></b>
+                <li tabindex="0"><b><a class="dropdown-selector"
+                    href="javascript:this.preventDefault;"><?=$selected_text
+                    ?></a></b>
                 <ul><?php
                 foreach ($options as $value => $text) {
                     if (empty($text) && !empty($value)) {?>
ViewGit